Bug 204124

Summary: [JSC] JSC GC relies on CodeBlock is not PreciseAllocation
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: JavaScriptCoreAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 201908    
Bug Blocks: 204039    
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2019-11-12 12:54:29 PST
...
Attachments
Patch (23.03 KB, patch)
2019-11-12 13:52 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (25.21 KB, patch)
2019-11-12 16:40 PST, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-11-12 13:23:54 PST
For now, we disable lower-tier-cells for CodeBlock.
Radar WebKit Bug Importer
Comment 2 2019-11-12 13:34:25 PST
<rdar://problem/57128580>
Yusuke Suzuki
Comment 3 2019-11-12 13:35:06 PST
<rdar://problem/57067238>
Yusuke Suzuki
Comment 4 2019-11-12 13:52:38 PST
Created attachment 383380 [details] Patch
Yusuke Suzuki
Comment 5 2019-11-12 16:40:22 PST
Created attachment 383403 [details] Patch
Yusuke Suzuki
Comment 6 2019-11-12 16:40:40 PST
Small refactoring is done.
Yusuke Suzuki
Comment 7 2019-11-12 16:44:12 PST
Comment on attachment 383403 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=383403&action=review > Source/JavaScriptCore/heap/IsoSubspacePerVM.cpp:33 > class IsoSubspacePerVM::AutoremovingIsoSubspace : public IsoSubspace { I strongly want to remove IsoSubspacePerVM anyway.
Yusuke Suzuki
Comment 8 2019-11-12 17:40:40 PST
Committed r252385: <https://trac.webkit.org/changeset/252385>
Note You need to log in before you can comment on or make changes to this bug.