Bug 102820

Summary:

Simplify style invalidation logic

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

cmarcelo, dglazkov, kling, macpherson, menard, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
for bots	buildbot: commit-queue-

Antti Koivisto

Reported 2012-11-20 09:17:50 PST

Get rid of requiresFullStyleRecalc flag, always invalidate in one place

Attachments
for bots (10.75 KB, patch) 2012-11-20 09:18 PST, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2012-11-20 09:18:55 PST

Created attachment 175232 [details] for bots

Build Bot

Comment 2 2012-11-20 12:11:14 PST

Comment on attachment 175232 [details] for bots Attachment 175232 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/14909700 New failing tests: fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html fast/regions/get-region-flow-ranges-horiz-bt.html css2.1/20110323/block-non-replaced-height-004.htm css2.1/20110323/block-non-replaced-height-006.htm fast/regions/flowed-content-bounding-client-rect-vertical.html fast/regions/get-region-flow-ranges-vert-rl.html fast/regions/flow-content-basic-vertical.html css2.1/20110323/block-non-replaced-height-002.htm fast/regions/element-region-overset-state-vertical-rl.html fast/events/overflow-scroll-fake-mouse-move.html fast/regions/text-region-split-horizontal-bt.html fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html css2.1/20110323/block-non-replaced-height-012.htm fast/regions/flowed-content-bounding-client-rect-vertical-rl.html fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html fast/regions/get-regions-by-content-horiz-bt.html fast/css/empty-generated-content.html css2.1/20110323/block-non-replaced-height-010.htm css2.1/20110323/block-non-replaced-height-008.htm fast/regions/get-region-flow-ranges-vert-lr.html fast/regions/get-region-flow-ranges-text-vert-lr.html fast/regions/flow-content-basic-vertical-rl.html fast/regions/get-regions-by-content-vert-rl.html fast/body-propagation/overflow/002.html fast/regions/get-regions-by-content-vert-lr.html css2.1/20110323/block-non-replaced-height-016.htm fast/loader/javascript-url-in-object.html css2.1/20110323/block-non-replaced-height-014.htm css2.1/t1204-root-e.html

WebKit Review Bot

Comment 3 2012-11-21 23:11:40 PST

Comment on attachment 175232 [details] for bots Attachment 175232 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14963216 New failing tests: fast/forms/range/slider-delete-while-dragging-thumb.html fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html fast/regions/get-region-flow-ranges-horiz-bt.html css2.1/20110323/block-non-replaced-height-004.htm css2.1/20110323/block-non-replaced-height-006.htm fast/regions/flowed-content-bounding-client-rect-vertical-rl.html fast/regions/flowed-content-bounding-client-rect-vertical.html fast/css/pending-stylesheet-repaint.html fast/regions/flow-content-basic-vertical.html css2.1/20110323/block-non-replaced-height-002.htm fast/regions/element-region-overset-state-vertical-rl.html fast/loader/text-document-wrapping.html fast/regions/get-region-flow-ranges-vert-rl.html fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html css2.1/20110323/block-non-replaced-height-012.htm fast/forms/range/slider-mouse-events.html fast/css/empty-generated-content.html css2.1/20110323/block-non-replaced-height-010.htm css2.1/20110323/block-non-replaced-height-008.htm fast/regions/get-region-flow-ranges-vert-lr.html fast/regions/flow-content-basic-vertical-rl.html fast/regions/get-region-flow-ranges-text-vert-lr.html fast/body-propagation/overflow/002.html css2.1/20110323/block-non-replaced-height-016.htm fast/loader/javascript-url-in-object.html css2.1/20110323/block-non-replaced-height-014.htm fast/forms/range/slider-onchange-event.html css2.1/t1204-root-e.html

Note You need to log in before you can comment on or make changes to this bug.